readline: validate AbortSignals and remove unused event listeners

aduh95 · aduh95 · commit 707dd77d8636 · 2021-09-16T23:16:42.000+02:00
PR-URL: #37947 Fixes: #37287 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
diff --git a/lib/readline.js b/lib/readline.js
@@ -48,6 +48,7 @@ const {
   inspect,
 } = require('internal/util/inspect');
 const { promisify } = require('internal/util');
+const { validateAbortSignal } = require('internal/validators');
 
 /**
  * @typedef {import('./stream.js').Readable} Readable
@@ -130,13 +131,22 @@ Interface.prototype.question = function(query, options, cb) {
   options = typeof options === 'object' && options !== null ? options : {};
 
   if (options.signal) {
+    validateAbortSignal(options.signal, 'options.signal');
     if (options.signal.aborted) {
       return;
     }
 
-    options.signal.addEventListener('abort', () => {
+    const onAbort = () => {
       this[kQuestionCancel]();
-    }, { once: true });
+    };
+    options.signal.addEventListener('abort', onAbort, { once: true });
+    const cleanup = () => {
+      options.signal.removeEventListener(onAbort);
+    };
+    cb = typeof cb === 'function' ? (answer) => {
+      cleanup();
+      return cb(answer);
+    } : cleanup;
   }
 
   if (typeof cb === 'function') {
@@ -151,13 +161,20 @@ Interface.prototype.question[promisify.custom] = function(query, options) {
   }
 
   return new Promise((resolve, reject) => {
-    this.question(query, options, resolve);
+    let cb = resolve;
 
     if (options.signal) {
-      options.signal.addEventListener('abort', () => {
+      const onAbort = () => {
         reject(new AbortError());
-      }, { once: true });
+      };
+      options.signal.addEventListener('abort', onAbort, { once: true });
+      cb = (answer) => {
+        options.signal.removeEventListener('abort', onAbort);
+        resolve(answer);
+      };
     }
+
+    this.question(query, options, cb);
   });
 };
 
diff --git a/lib/readline/promises.js b/lib/readline/promises.js
@@ -16,6 +16,7 @@ const {
 const {
   AbortError,
 } = require('internal/errors');
+const { validateAbortSignal } = require('internal/validators');
 
 class Interface extends _Interface {
   // eslint-disable-next-line no-useless-constructor
@@ -24,18 +25,26 @@ class Interface extends _Interface {
   }
   question(query, options = {}) {
     return new Promise((resolve, reject) => {
-      if (options.signal) {
+      let cb = resolve;
+
+      if (options?.signal) {
+        validateAbortSignal(options.signal, 'options.signal');
         if (options.signal.aborted) {
           return reject(new AbortError());
         }
 
-        options.signal.addEventListener('abort', () => {
+        const onAbort = () => {
           this[kQuestionCancel]();
           reject(new AbortError());
-        }, { once: true });
+        };
+        options.signal.addEventListener('abort', onAbort, { once: true });
+        cb = (answer) => {
+          options.signal.removeEventListener('abort', onAbort);
+          resolve(answer);
+        };
       }
 
-      super.question(query, resolve);
+      super.question(query, cb);
     });
   }
 }
