crypto: fix importKey required argument count check

panva · aduh95 · commit 6f975db8af44 · 2026-03-10T14:48:53.000+01:00
PR-URL: #62099 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/lib/internal/crypto/webcrypto.js b/lib/internal/crypto/webcrypto.js
@@ -865,7 +865,7 @@ async function importKey(
 
   webidl ??= require('internal/crypto/webidl');
   const prefix = "Failed to execute 'importKey' on 'SubtleCrypto'";
-  webidl.requiredArguments(arguments.length, 4, { prefix });
+  webidl.requiredArguments(arguments.length, 5, { prefix });
   format = webidl.converters.KeyFormat(format, {
     prefix,
     context: '1st argument',
diff --git a/test/parallel/test-webcrypto-export-import.js b/test/parallel/test-webcrypto-export-import.js
@@ -435,3 +435,11 @@ if (!process.features.openssl_is_boringssl) {
     subtle.importKey('jwk', jwk, { name: 'HMAC', hash: 'SHA3-256' }, false, ['sign', 'verify']).then(common.mustCall());
   }
 }
+
+{
+  const keyData = new Uint8Array(32);
+  assert.rejects(
+    subtle.importKey('raw', keyData, { name: 'HMAC', hash: 'SHA-256' }, false),
+    { code: 'ERR_MISSING_ARGS' }
+  ).then(common.mustCall());
+}

Original file line number	Diff line number	Diff line change
`@@ -435,3 +435,11 @@ if (!process.features.openssl_is_boringssl) {`
`435`	`435`	`subtle.importKey('jwk', jwk, { name: 'HMAC', hash: 'SHA3-256' }, false, ['sign', 'verify']).then(common.mustCall());`
`436`	`436`	`}`
`437`	`437`	`}`
	`438`	`+`
	`439`	`+{`
	`440`	`+ const keyData = new Uint8Array(32);`
	`441`	`+ assert.rejects(`
	`442`	`+ subtle.importKey('raw', keyData, { name: 'HMAC', hash: 'SHA-256' }, false),`
	`443`	`+ { code: 'ERR_MISSING_ARGS' }`
	`444`	`+ ).then(common.mustCall());`
	`445`	`+}`