buffer: also alias BigUInt methods

addaleax · addaleax · commit 6ee800f0c3f9 · 2020-09-28T10:59:35.000+02:00
These were overlooked in 5864fca because of the extra `Big` in the name. :) Refs: #34729 PR-URL: #34960 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/doc/api/buffer.md b/doc/api/buffer.md
@@ -1375,6 +1375,10 @@ values.
 ### `buf.readBigUInt64BE([offset])`
 <!-- YAML
 added: v12.0.0
+changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/34960
+    description: This function is also available as `buf.readBigUint64BE()`.
 -->
 
 * `offset` {integer} Number of bytes to skip before starting to read. Must
@@ -1396,6 +1400,10 @@ console.log(buf.readBigUInt64BE(0));
 added:
  - v12.0.0
  - v10.20.0
+changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/34960
+    description: This function is also available as `buf.readBigUint64LE()`.
 -->
 
 * `offset` {integer} Number of bytes to skip before starting to read. Must
@@ -2298,6 +2306,10 @@ console.log(buf);
 added:
  - v12.0.0
  - v10.20.0
+changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/34960
+    description: This function is also available as `buf.writeBigUint64BE()`.
 -->
 
 * `value` {bigint} Number to be written to `buf`.
@@ -2319,6 +2331,10 @@ console.log(buf);
 ### `buf.writeBigUInt64LE(value[, offset])`
 <!-- YAML
 added: v12.0.0
+changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/34960
+    description: This function is also available as `buf.writeBigUint64LE()`.
 -->
 
 * `value` {bigint} Number to be written to `buf`.
diff --git a/lib/internal/buffer.js b/lib/internal/buffer.js
@@ -951,10 +951,14 @@ class FastBuffer extends Uint8Array {}
 function addBufferPrototypeMethods(proto) {
   proto.readBigUInt64LE = readBigUInt64LE,
   proto.readBigUInt64BE = readBigUInt64BE,
+  proto.readBigUint64LE = readBigUInt64LE,
+  proto.readBigUint64BE = readBigUInt64BE,
   proto.readBigInt64LE = readBigInt64LE,
   proto.readBigInt64BE = readBigInt64BE,
   proto.writeBigUInt64LE = writeBigUInt64LE,
   proto.writeBigUInt64BE = writeBigUInt64BE,
+  proto.writeBigUint64LE = writeBigUInt64LE,
+  proto.writeBigUint64BE = writeBigUInt64BE,
   proto.writeBigInt64LE = writeBigInt64LE,
   proto.writeBigInt64BE = writeBigInt64BE,
 
diff --git a/test/parallel/test-buffer-writeuint.js b/test/parallel/test-buffer-writeuint.js
@@ -222,7 +222,8 @@ const assert = require('assert');
 }
 
 for (const fn of [
-  'UInt8', 'UInt16LE', 'UInt16BE', 'UInt32LE', 'UInt32BE', 'UIntLE', 'UIntBE'
+  'UInt8', 'UInt16LE', 'UInt16BE', 'UInt32LE', 'UInt32BE', 'UIntLE', 'UIntBE',
+  'BigUInt64LE', 'BigUInt64BE',
 ]) {
   const p = Buffer.prototype;
   const lowerFn = fn.replace(/UInt/, 'Uint');

Original file line number	Diff line number	Diff line change
`@@ -222,7 +222,8 @@ const assert = require('assert');`
`222`	`222`	`}`
`223`	`223`
`224`	`224`	`for (const fn of [`
`225`		`- 'UInt8', 'UInt16LE', 'UInt16BE', 'UInt32LE', 'UInt32BE', 'UIntLE', 'UIntBE'`
	`225`	`+ 'UInt8', 'UInt16LE', 'UInt16BE', 'UInt32LE', 'UInt32BE', 'UIntLE', 'UIntBE',`
	`226`	`+ 'BigUInt64LE', 'BigUInt64BE',`
`226`	`227`	`]) {`
`227`	`228`	`const p = Buffer.prototype;`
`228`	`229`	`const lowerFn = fn.replace(/UInt/, 'Uint');`