src: disable V8 external memory reasonable size check · nodejs/node@6e9d44d · GitHub
Skip to content

Commit 6e9d44d

Browse files
bitpshraduh95
authored andcommitted
src: disable V8 external memory reasonable size check
V8 aborts the process when external memory grows by more than --external-memory-max-reasonable-size gigabytes in a single step. The 32 GB default is a Chromium-oriented sanity check; allocating a buffer larger than that is legitimate in Node and should raise a RangeError rather than terminate the process. Default the flag to 0 unless the user supplied a value, alongside the other V8 defaults Node sets explicitly. Fixes: #65534 Signed-off-by: Paul Bouchon <mail@bitpshr.net> PR-URL: #65589 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 3f67df1 commit 6e9d44d

2 files changed

Lines changed: 47 additions & 0 deletions

File tree

‎src/node.cc‎

Lines changed: 14 additions & 0 deletions
Lines changed: 33 additions & 0 deletions

0 commit comments

Comments
 (0)