src: fix abort when taking a heap snapshot

bnoordhuis · addaleax · commit 6e7aa3d8f421 · 2018-02-26T23:42:46.000+01:00
Remove an erroneous CHECK that asserted the persistent object's internal field pointer still pointed to a valid object. If ClearWrap() has been called, the field pointer equals nullptr and that is expected behavior. PR-URL: #18898 Fixes: #18256 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matheus Marchini <matheus@sthima.com>
diff --git a/src/async_wrap.cc b/src/async_wrap.cc
@@ -128,7 +128,7 @@ RetainedObjectInfo* WrapperInfo(uint16_t class_id, Local<Value> wrapper) {
   CHECK_GT(object->InternalFieldCount(), 0);
 
   AsyncWrap* wrap = Unwrap<AsyncWrap>(object);
-  CHECK_NE(nullptr, wrap);
+  if (wrap == nullptr) return nullptr;  // ClearWrap() already called.
 
   return new RetainedAsyncInfo(class_id, wrap);
 }

Original file line number	Diff line number	Diff line change
`@@ -128,7 +128,7 @@ RetainedObjectInfo* WrapperInfo(uint16_t class_id, Local<Value> wrapper) {`
`128`	`128`	`CHECK_GT(object->InternalFieldCount(), 0);`
`129`	`129`
`130`	`130`	`AsyncWrap* wrap = Unwrap<AsyncWrap>(object);`
`131`		`- CHECK_NE(nullptr, wrap);`
	`131`	`+ if (wrap == nullptr) return nullptr; // ClearWrap() already called.`
`132`	`132`
`133`	`133`	`return new RetainedAsyncInfo(class_id, wrap);`
`134`	`134`	`}`