test: reduce flakiness of test-assert-esm-cjs-message-verify

aduh95 · marco-ippolito · commit 6d0b8ded00cc · 2024-08-19T10:32:43.000+02:00
PR-URL: #53967 Fixes: #53962 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
diff --git a/test/parallel/test-assert-esm-cjs-message-verify.js b/test/parallel/test-assert-esm-cjs-message-verify.js
@@ -1,51 +1,31 @@
 'use strict';
 
 const { spawnPromisified } = require('../common');
-const tmpdir = require('../common/tmpdir');
-const assert = require('assert');
-const { writeFileSync, unlink } = require('fs');
-const { describe, after, it } = require('node:test');
-
-tmpdir.refresh();
+const assert = require('node:assert');
+const { describe, it } = require('node:test');
 
 const fileImports = {
-  cjs: 'const assert = require("assert");',
-  mjs: 'import assert from "assert";',
+  commonjs: 'const assert = require("assert");',
+  module: 'import assert from "assert";',
 };
 
-const fileNames = [];
-
-for (const [ext, header] of Object.entries(fileImports)) {
-  const fileName = `test-file.${ext}`;
-  // Store the generated filesnames in an array
-  fileNames.push(`${tmpdir.path}/${fileName}`);
-
-  writeFileSync(tmpdir.resolve(fileName), `${header}\nassert.ok(0 === 2);`);
-}
-
 describe('ensure the assert.ok throwing similar error messages for esm and cjs files', () => {
-  const nodejsPath = `${process.execPath}`;
-  const errorsMessages = [];
-
   it('should return code 1 for each command', async () => {
-    for (const fileName of fileNames) {
-      const { stderr, code } = await spawnPromisified(nodejsPath, [fileName]);
+    const errorsMessages = [];
+    for (const [inputType, header] of Object.entries(fileImports)) {
+      const { stderr, code } = await spawnPromisified(process.execPath, [
+        '--input-type',
+        inputType,
+        '--eval',
+        `${header}\nassert.ok(0 === 2);\n`,
+      ]);
       assert.strictEqual(code, 1);
       // For each error message, filter the lines which will starts with AssertionError
       errorsMessages.push(
         stderr.split('\n').find((s) => s.startsWith('AssertionError'))
       );
     }
-  });
-
-  after(() => {
     assert.strictEqual(errorsMessages.length, 2);
     assert.deepStrictEqual(errorsMessages[0], errorsMessages[1]);
-
-    for (const fileName of fileNames) {
-      unlink(fileName, () => {});
-    }
-
-    tmpdir.refresh();
   });
 });
