src: implement per-process native Debug() printer

joyeecheung · MylesBorins · commit 6aa797b5466b · 2020-03-10T18:00:31.000-04:00
This patch adds a per-process native Debug() printer that can be called when an Environment is not available. PR-URL: #31884 Reviewed-By: Anna Henningsen <anna@addaleax.net>
diff --git a/src/debug_utils-inl.h b/src/debug_utils-inl.h
@@ -164,6 +164,20 @@ inline void FORCE_INLINE Debug(AsyncWrap* async_wrap,
   Debug(async_wrap, format.c_str(), std::forward<Args>(args)...);
 }
 
+namespace per_process {
+
+template <typename... Args>
+inline void FORCE_INLINE Debug(DebugCategory cat,
+                               const char* format,
+                               Args&&... args) {
+  Debug(&enabled_debug_list, cat, format, std::forward<Args>(args)...);
+}
+
+inline void FORCE_INLINE Debug(DebugCategory cat, const char* message) {
+  Debug(&enabled_debug_list, cat, message);
+}
+
+}  // namespace per_process
 }  // namespace node
 
 #endif  // defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
diff --git a/src/debug_utils.cc b/src/debug_utils.cc
@@ -54,6 +54,9 @@
 #endif  // _WIN32
 
 namespace node {
+namespace per_process {
+EnabledDebugList enabled_debug_list;
+}
 
 void EnabledDebugList::Parse(Environment* env) {
   std::string cats;
diff --git a/src/debug_utils.h b/src/debug_utils.h
@@ -161,6 +161,16 @@ class NativeSymbolDebuggingContext {
 void CheckedUvLoopClose(uv_loop_t* loop);
 void PrintLibuvHandleInformation(uv_loop_t* loop, FILE* stream);
 
+namespace per_process {
+extern EnabledDebugList enabled_debug_list;
+
+template <typename... Args>
+inline void FORCE_INLINE Debug(DebugCategory cat,
+                               const char* format,
+                               Args&&... args);
+
+inline void FORCE_INLINE Debug(DebugCategory cat, const char* message);
+}  // namespace per_process
 }  // namespace node
 
 #endif  // defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
diff --git a/src/node.cc b/src/node.cc
@@ -916,6 +916,10 @@ void Init(int* argc,
 }
 
 InitializationResult InitializeOncePerProcess(int argc, char** argv) {
+  // Initialized the enabled list for Debug() calls with system
+  // environment variables.
+  per_process::enabled_debug_list.Parse(nullptr);
+
   atexit(ResetStdio);
   PlatformInit();
 

Original file line number	Diff line number	Diff line change
`@@ -916,6 +916,10 @@ void Init(int* argc,`
`916`	`916`	`}`
`917`	`917`
`918`	`918`	`InitializationResult InitializeOncePerProcess(int argc, char** argv) {`
	`919`	`+ // Initialized the enabled list for Debug() calls with system`
	`920`	`+ // environment variables.`
	`921`	`+ per_process::enabled_debug_list.Parse(nullptr);`
	`922`	`+`
`919`	`923`	`atexit(ResetStdio);`
`920`	`924`	`PlatformInit();`
`921`	`925`