build: work around bug in MSBuild v16.10.0

targos · danielleadams · commit 6986154b303a · 2021-06-01T08:18:48.000-04:00
This allows to build Node.js at the (temporary) cost of longer build times. Refs: #38872 Refs: https://github.com/dotnet/msbuild/releases/tag/v16.10.0 Refs: dotnet/msbuild#6465 Refs: dotnet/msbuild#6373 PR-URL: #38873 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
diff --git a/vcbuild.bat b/vcbuild.bat
@@ -334,6 +334,8 @@ if "%target%"=="Build" (
   if defined cctest set target="Build"
 )
 if "%target%"=="node" if exist "%config%\cctest.exe" del "%config%\cctest.exe"
+@rem TODO(targos): Remove next line after MSBuild 16.10.1 is released.
+if "%target%"=="node" set target="Build"
 if defined msbuild_args set "extra_msbuild_args=%extra_msbuild_args% %msbuild_args%"
 @rem Setup env variables to use multiprocessor build
 set UseMultiToolTask=True

Original file line number	Diff line number	Diff line change
`@@ -334,6 +334,8 @@ if "%target%"=="Build" (`
`334`	`334`	`if defined cctest set target="Build"`
`335`	`335`	`)`
`336`	`336`	`if "%target%"=="node" if exist "%config%\cctest.exe" del "%config%\cctest.exe"`
	`337`	`+@rem TODO(targos): Remove next line after MSBuild 16.10.1 is released.`
	`338`	`+if "%target%"=="node" set target="Build"`
`337`	`339`	`if defined msbuild_args set "extra_msbuild_args=%extra_msbuild_args% %msbuild_args%"`
`338`	`340`	`@rem Setup env variables to use multiprocessor build`
`339`	`341`	`set UseMultiToolTask=True`