test: avoid using Object.prototype methods directly on objects

Trott · danielleadams · commit 673c1fd5aed1 · 2022-03-14T09:32:14.000-04:00
This prepares us to enable the no-prototype-builtins ESLint rule. Refs: https://eslint.org/docs/rules/no-prototype-builtins PR-URL: #41801 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
diff --git a/test/parallel/test-console-group.js b/test/parallel/test-console-group.js
@@ -151,7 +151,7 @@ function teardown() {
 // Check that the kGroupIndent symbol property is not enumerable
 {
   const keys = Reflect.ownKeys(console)
-                      .filter((val) => console.propertyIsEnumerable(val))
+                      .filter((val) => Object.prototype.propertyIsEnumerable.call(console, val))
                       .map((val) => val.toString());
   assert(!keys.includes('Symbol(groupIndent)'),
          'groupIndent should not be enumerable');
diff --git a/test/parallel/test-stream-base-prototype-accessors-enumerability.js b/test/parallel/test-stream-base-prototype-accessors-enumerability.js
@@ -14,8 +14,8 @@ const { internalBinding } = require('internal/test/binding');
 const TTY = internalBinding('tty_wrap').TTY;
 
 {
-  assert.strictEqual(TTY.prototype.propertyIsEnumerable('bytesRead'), false);
-  assert.strictEqual(TTY.prototype.propertyIsEnumerable('fd'), false);
-  assert.strictEqual(
-    TTY.prototype.propertyIsEnumerable('_externalStream'), false);
+  const ttyIsEnumerable = Object.prototype.propertyIsEnumerable.bind(TTY);
+  assert.strictEqual(ttyIsEnumerable('bytesRead'), false);
+  assert.strictEqual(ttyIsEnumerable('fd'), false);
+  assert.strictEqual(ttyIsEnumerable('_externalStream'), false);
 }

Original file line number	Diff line number	Diff line change
`@@ -151,7 +151,7 @@ function teardown() {`
`151`	`151`	`// Check that the kGroupIndent symbol property is not enumerable`
`152`	`152`	`{`
`153`	`153`	`const keys = Reflect.ownKeys(console)`
`154`		`- .filter((val) => console.propertyIsEnumerable(val))`
	`154`	`+ .filter((val) => Object.prototype.propertyIsEnumerable.call(console, val))`
`155`	`155`	`.map((val) => val.toString());`
`156`	`156`	`assert(!keys.includes('Symbol(groupIndent)'),`
`157`	`157`	`'groupIndent should not be enumerable');`
Original file line number	Diff line number	Diff line change
`@@ -14,8 +14,8 @@ const { internalBinding } = require('internal/test/binding');`
`14`	`14`	`const TTY = internalBinding('tty_wrap').TTY;`
`15`	`15`
`16`	`16`	`{`
`17`		`- assert.strictEqual(TTY.prototype.propertyIsEnumerable('bytesRead'), false);`
`18`		`- assert.strictEqual(TTY.prototype.propertyIsEnumerable('fd'), false);`
`19`		`- assert.strictEqual(`
`20`		`- TTY.prototype.propertyIsEnumerable('_externalStream'), false);`
	`17`	`+ const ttyIsEnumerable = Object.prototype.propertyIsEnumerable.bind(TTY);`
	`18`	`+ assert.strictEqual(ttyIsEnumerable('bytesRead'), false);`
	`19`	`+ assert.strictEqual(ttyIsEnumerable('fd'), false);`
	`20`	`+ assert.strictEqual(ttyIsEnumerable('_externalStream'), false);`
`21`	`21`	`}`