lib: use === in _http_server and _tls_wrap

walterbm · MylesBorins · commit 6632b3d1abf4 · 2016-12-20T14:57:20.000-05:00
Minor fix to favor strict equality in http_server.js and tls_wrap.js to ensure accurate comparisons without type coercion. PR-URL: #9849 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/lib/_http_server.js b/lib/_http_server.js
@@ -524,7 +524,7 @@ function connectionListener(socket) {
     }
 
     if (req.headers.expect !== undefined &&
-        (req.httpVersionMajor == 1 && req.httpVersionMinor == 1)) {
+        (req.httpVersionMajor === 1 && req.httpVersionMinor === 1)) {
       if (continueExpression.test(req.headers.expect)) {
         res._expect_continue = true;
 
diff --git a/lib/_tls_wrap.js b/lib/_tls_wrap.js
@@ -545,7 +545,7 @@ TLSSocket.prototype.renegotiate = function(options, callback) {
 };
 
 TLSSocket.prototype.setMaxSendFragment = function setMaxSendFragment(size) {
-  return this._handle.setMaxSendFragment(size) == 1;
+  return this._handle.setMaxSendFragment(size) === 1;
 };
 
 TLSSocket.prototype.getTLSTicket = function getTLSTicket() {

Original file line number	Diff line number	Diff line change
`@@ -524,7 +524,7 @@ function connectionListener(socket) {`
`524`	`524`	`}`
`525`	`525`
`526`	`526`	`if (req.headers.expect !== undefined &&`
`527`		`- (req.httpVersionMajor == 1 && req.httpVersionMinor == 1)) {`
	`527`	`+ (req.httpVersionMajor === 1 && req.httpVersionMinor === 1)) {`
`528`	`528`	`if (continueExpression.test(req.headers.expect)) {`
`529`	`529`	`res._expect_continue = true;`
`530`	`530`