assert: revert breaking change

BridgeAR · BethGriggs · commit 62fb5dbec557 · 2018-12-11T15:18:30.000Z
It was not intended to change the `assert.doesNotThrow()` message with #23223. This reverts the breaking behavior to the one before. PR-URL: #24786 Refs: #23223 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
diff --git a/lib/assert.js b/lib/assert.js
@@ -782,7 +782,7 @@ function expectsNoError(stackStartFn, actual, error, message) {
       actual,
       expected: error,
       operator: stackStartFn.name,
-      message: `Got unwanted ${fnType}${details}\n${actual.message}`,
+      message: `Got unwanted ${fnType}${details}`,
       stackStartFn
     });
   }
diff --git a/test/parallel/test-assert-async.js b/test/parallel/test-assert-async.js
@@ -34,7 +34,7 @@ common.crashOnUnhandledRejection();
         assert(err instanceof assert.AssertionError,
                `${err.name} is not instance of AssertionError`);
         assert.strictEqual(err.code, 'ERR_ASSERTION');
-        assert(/^Got unwanted rejection\.\n$/.test(err.message));
+        assert(/^Got unwanted rejection\.$/.test(err.message));
         assert.strictEqual(err.operator, 'doesNotReject');
         assert.ok(!err.stack.includes('at Function.doesNotReject'));
         return true;
diff --git a/test/parallel/test-assert.js b/test/parallel/test-assert.js
@@ -460,7 +460,7 @@ common.expectsError(
     type: a.AssertionError,
     code: 'ERR_ASSERTION',
     operator: 'doesNotThrow',
-    message: 'Got unwanted exception: user message\n[object Object]'
+    message: 'Got unwanted exception: user message'
   }
 );
 

Original file line number	Diff line number	Diff line change
`@@ -782,7 +782,7 @@ function expectsNoError(stackStartFn, actual, error, message) {`
`782`	`782`	`actual,`
`783`	`783`	`expected: error,`
`784`	`784`	`operator: stackStartFn.name,`
`785`		- message: `Got unwanted ${fnType}${details}\n${actual.message}`,
	`785`	+ message: `Got unwanted ${fnType}${details}`,
`786`	`786`	`stackStartFn`
`787`	`787`	`});`
`788`	`788`	`}`
Original file line number	Diff line number	Diff line change
`@@ -460,7 +460,7 @@ common.expectsError(`
`460`	`460`	`type: a.AssertionError,`
`461`	`461`	`code: 'ERR_ASSERTION',`
`462`	`462`	`operator: 'doesNotThrow',`
`463`		`- message: 'Got unwanted exception: user message\n[object Object]'`
	`463`	`+ message: 'Got unwanted exception: user message'`
`464`	`464`	`}`
`465`	`465`	`);`
`466`	`466`