tools: do not disable quotes rule in .eslintrc.js

Trott · targos · commit 6285fe94f6dd · 2018-06-19T08:59:44.000+02:00
Re-enable `quotes` rule in .eslintrc.js and fix code to abide by the rule. As a bonus, this makes the code (IMO, anyway) more readable. (It certainly isn't *less* readable, at least not IMO.) PR-URL: #21338 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -147,32 +147,32 @@ module.exports = {
         message: '__defineSetter__ is deprecated.',
       }
     ],
-    /* eslint-disable max-len, quotes */
+    /* eslint-disable max-len */
     // If this list is modified, please copy the change to lib/.eslintrc.yaml
     'no-restricted-syntax': [
       'error',
       {
         selector: "CallExpression[callee.object.name='assert'][callee.property.name='doesNotThrow']",
-        message: "Please replace `assert.doesNotThrow()` and add a comment next to the code instead."
+        message: 'Please replace `assert.doesNotThrow()` and add a comment next to the code instead.'
       },
       {
-        selector: `CallExpression[callee.object.name='assert'][callee.property.name='rejects'][arguments.length<2]`,
+        selector: "CallExpression[callee.object.name='assert'][callee.property.name='rejects'][arguments.length<2]",
         message: 'assert.rejects() must be invoked with at least two arguments.',
       },
       {
-        selector: `CallExpression[callee.object.name='assert'][callee.property.name='throws'][arguments.1.type='Literal']:not([arguments.1.regex])`,
+        selector: "CallExpression[callee.object.name='assert'][callee.property.name='throws'][arguments.1.type='Literal']:not([arguments.1.regex])",
         message: 'Use an object as second argument of assert.throws()',
       },
       {
-        selector: `CallExpression[callee.object.name='assert'][callee.property.name='throws'][arguments.length<2]`,
+        selector: "CallExpression[callee.object.name='assert'][callee.property.name='throws'][arguments.length<2]",
         message: 'assert.throws() must be invoked with at least two arguments.',
       },
       {
-        selector: `CallExpression[callee.name='setTimeout'][arguments.length<2]`,
+        selector: "CallExpression[callee.name='setTimeout'][arguments.length<2]",
         message: 'setTimeout() must be invoked with at least two arguments.',
       },
       {
-        selector: `CallExpression[callee.name='setInterval'][arguments.length<2]`,
+        selector: "CallExpression[callee.name='setInterval'][arguments.length<2]",
         message: 'setInterval() must be invoked with at least 2 arguments.',
       },
       {

Original file line number	Diff line number	Diff line change
`@@ -147,32 +147,32 @@ module.exports = {`
`147`	`147`	`message: '__defineSetter__ is deprecated.',`
`148`	`148`	`}`
`149`	`149`	`],`
`150`		`- /* eslint-disable max-len, quotes */`
	`150`	`+ /* eslint-disable max-len */`
`151`	`151`	`// If this list is modified, please copy the change to lib/.eslintrc.yaml`
`152`	`152`	`'no-restricted-syntax': [`
`153`	`153`	`'error',`
`154`	`154`	`{`
`155`	`155`	`selector: "CallExpression[callee.object.name='assert'][callee.property.name='doesNotThrow']",`
`156`		- message: "Please replace `assert.doesNotThrow()` and add a comment next to the code instead."
	`156`	+ message: 'Please replace `assert.doesNotThrow()` and add a comment next to the code instead.'
`157`	`157`	`},`
`158`	`158`	`{`
`159`		- selector: `CallExpression[callee.object.name='assert'][callee.property.name='rejects'][arguments.length<2]`,
	`159`	`+ selector: "CallExpression[callee.object.name='assert'][callee.property.name='rejects'][arguments.length<2]",`
`160`	`160`	`message: 'assert.rejects() must be invoked with at least two arguments.',`
`161`	`161`	`},`
`162`	`162`	`{`
`163`		- selector: `CallExpression[callee.object.name='assert'][callee.property.name='throws'][arguments.1.type='Literal']:not([arguments.1.regex])`,
	`163`	`+ selector: "CallExpression[callee.object.name='assert'][callee.property.name='throws'][arguments.1.type='Literal']:not([arguments.1.regex])",`
`164`	`164`	`message: 'Use an object as second argument of assert.throws()',`
`165`	`165`	`},`
`166`	`166`	`{`
`167`		- selector: `CallExpression[callee.object.name='assert'][callee.property.name='throws'][arguments.length<2]`,
	`167`	`+ selector: "CallExpression[callee.object.name='assert'][callee.property.name='throws'][arguments.length<2]",`
`168`	`168`	`message: 'assert.throws() must be invoked with at least two arguments.',`
`169`	`169`	`},`
`170`	`170`	`{`
`171`		- selector: `CallExpression[callee.name='setTimeout'][arguments.length<2]`,
	`171`	`+ selector: "CallExpression[callee.name='setTimeout'][arguments.length<2]",`
`172`	`172`	`message: 'setTimeout() must be invoked with at least two arguments.',`
`173`	`173`	`},`
`174`	`174`	`{`
`175`		- selector: `CallExpression[callee.name='setInterval'][arguments.length<2]`,
	`175`	`+ selector: "CallExpression[callee.name='setInterval'][arguments.length<2]",`
`176`	`176`	`message: 'setInterval() must be invoked with at least 2 arguments.',`
`177`	`177`	`},`
`178`	`178`	`{`