process: runtime deprecate multipleResolves

benjamingr · benjamingr · commit 60b8e795993c · 2022-02-13T23:30:36.000+02:00
PR-URL: #41896 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md
@@ -3075,12 +3075,15 @@ the errors used for value type validation.
 
 <!-- YAML
 changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/41896
+    description: Runtime deprecation.
   - version: REPLACEME
     pr-url: https://github.com/nodejs/node/pull/41872
     description: Documentation-only deprecation.
 -->
 
-Type: Documentation-only
+Type: Runtime.
 
 This event was deprecated because it did not work with V8 promise combinators
 which diminished its usefulness.
diff --git a/lib/internal/process/promises.js b/lib/internal/process/promises.js
@@ -20,6 +20,8 @@ const {
   setPromiseRejectCallback
 } = internalBinding('task_queue');
 
+const { deprecate } = require('internal/util');
+
 const {
   noSideEffectsToString,
   triggerUncaughtException
@@ -124,11 +126,18 @@ function promiseRejectHandler(type, promise, reason) {
   }
 }
 
+const multipleResolvesDeprecate = deprecate(
+  () => {},
+  'The multipleResolves event has been deprecated.',
+  'DEPXXXX'
+);
 function resolveError(type, promise, reason) {
   // We have to wrap this in a next tick. Otherwise the error could be caught by
   // the executed promise.
   process.nextTick(() => {
-    process.emit('multipleResolves', type, promise, reason);
+    if (process.emit('multipleResolves', type, promise, reason)) {
+      multipleResolvesDeprecate();
+    }
   });
 }
 
diff --git a/test/parallel/test-warn-multipleResolves.mjs b/test/parallel/test-warn-multipleResolves.mjs
@@ -0,0 +1,14 @@
+import { expectWarning, mustCall } from '../common/index.mjs';
+
+expectWarning(
+  'DeprecationWarning',
+  'The multipleResolves event has been deprecated.',
+  'DEPXXXX',
+);
+
+process.on('multipleResolves', mustCall());
+
+new Promise((resolve) => {
+  resolve();
+  resolve();
+});
