child_process: set shell to false in fork()

Alex Gresnel · jasnell · commit 607832d3c339 · 2017-09-20T09:32:34.000-07:00
This commit ensures that spawn()'s shell option is unconditionally set to false when fork() is called. Refs: #15299 Fixes: #13983 PR-URL: #15352 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/doc/api/child_process.md b/doc/api/child_process.md
@@ -356,6 +356,9 @@ output on this fd is expected to be line delimited JSON objects.
 *Note*: Unlike the fork(2) POSIX system call, `child_process.fork()` does
 not clone the current process.
 
+*Note*: The `shell` option available in [`child_process.spawn()`][] is not
+supported by `child_process.fork()` and will be ignored if set.
+
 ### child_process.spawn(command[, args][, options])
 <!-- YAML
 added: v0.1.90
diff --git a/lib/child_process.js b/lib/child_process.js
@@ -95,6 +95,7 @@ exports.fork = function(modulePath /*, args, options*/) {
   }
 
   options.execPath = options.execPath || process.execPath;
+  options.shell = false;
 
   return spawn(options.execPath, args, options);
 };

Original file line number	Diff line number	Diff line change
`@@ -95,6 +95,7 @@ exports.fork = function(modulePath /, args, options/) {`
`95`	`95`	`}`
`96`	`96`
`97`	`97`	`options.execPath = options.execPath \|\| process.execPath;`
	`98`	`+ options.shell = false;`
`98`	`99`
`99`	`100`	`return spawn(options.execPath, args, options);`
`100`	`101`	`};`