buffer: make Buffer work with resizable ArrayBuffer

jasnell · ruyadorno · commit 6023e1bdb275 · 2024-11-27T01:23:23.000-05:00
Fixes: #52195 PR-URL: #55377 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
diff --git a/lib/buffer.js b/lib/buffer.js
@@ -504,9 +504,7 @@ function fromArrayBuffer(obj, byteOffset, length) {
   if (maxLength < 0)
     throw new ERR_BUFFER_OUT_OF_BOUNDS('offset');
 
-  if (length === undefined) {
-    length = maxLength;
-  } else {
+  if (length !== undefined) {
     // Convert length to non-negative integer.
     length = +length;
     if (length > 0) {
diff --git a/test/parallel/test-buffer-resizable.js b/test/parallel/test-buffer-resizable.js
@@ -0,0 +1,29 @@
+// Flags: --no-warnings
+'use strict';
+
+require('../common');
+const { Buffer } = require('node:buffer');
+const { strictEqual } = require('node:assert');
+const { describe, it } = require('node:test');
+
+describe('Using resizable ArrayBuffer with Buffer...', () => {
+  it('works as expected', () => {
+    const ab = new ArrayBuffer(10, { maxByteLength: 20 });
+    const buffer = Buffer.from(ab, 1);
+    strictEqual(buffer.byteLength, 9);
+    ab.resize(15);
+    strictEqual(buffer.byteLength, 14);
+    ab.resize(5);
+    strictEqual(buffer.byteLength, 4);
+  });
+
+  it('works with the deprecated constructor also', () => {
+    const ab = new ArrayBuffer(10, { maxByteLength: 20 });
+    const buffer = new Buffer(ab, 1);
+    strictEqual(buffer.byteLength, 9);
+    ab.resize(15);
+    strictEqual(buffer.byteLength, 14);
+    ab.resize(5);
+    strictEqual(buffer.byteLength, 4);
+  });
+});
