stream: fix Writable.destroy performance regression

ronag · UlisesGascon · commit 6012e3e781ba · 2023-12-11T11:12:15.000Z
Ref: #50409 PR-URL: #50478 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
diff --git a/lib/internal/streams/writable.js b/lib/internal/streams/writable.js
@@ -1105,7 +1105,7 @@ Writable.prototype.destroy = function(err, cb) {
   const state = this._writableState;
 
   // Invoke pending callbacks.
-  if ((state[kState] & (kBuffered | kOnFinished | kDestroyed)) !== kDestroyed) {
+  if ((state[kState] & (kBuffered | kOnFinished)) !== 0 && (state[kState] & kDestroyed) === 0) {
     process.nextTick(errorBuffer, state);
   }
 

Original file line number	Diff line number	Diff line change
`@@ -1105,7 +1105,7 @@ Writable.prototype.destroy = function(err, cb) {`
`1105`	`1105`	`const state = this._writableState;`
`1106`	`1106`
`1107`	`1107`	`// Invoke pending callbacks.`
`1108`		`- if ((state[kState] & (kBuffered \| kOnFinished \| kDestroyed)) !== kDestroyed) {`
	`1108`	`+ if ((state[kState] & (kBuffered \| kOnFinished)) !== 0 && (state[kState] & kDestroyed) === 0) {`
`1109`	`1109`	`process.nextTick(errorBuffer, state);`
`1110`	`1110`	`}`
`1111`	`1111`