src: fix readability/inheritance cpplint warnings

bnoordhuis · Fishrock123 · commit 5fd158568f93 · 2016-07-05T22:36:39.000+02:00
PR-URL: #7462 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
diff --git a/src/async-wrap.cc b/src/async-wrap.cc
@@ -38,11 +38,11 @@ class RetainedAsyncInfo: public RetainedObjectInfo {
  public:
   explicit RetainedAsyncInfo(uint16_t class_id, AsyncWrap* wrap);
 
-  virtual void Dispose() override;
-  virtual bool IsEquivalent(RetainedObjectInfo* other) override;
-  virtual intptr_t GetHash() override;
-  virtual const char* GetLabel() override;
-  virtual intptr_t GetSizeInBytes() override;
+  void Dispose() override;
+  bool IsEquivalent(RetainedObjectInfo* other) override;
+  intptr_t GetHash() override;
+  const char* GetLabel() override;
+  intptr_t GetSizeInBytes() override;
 
  private:
   const char* label_;
diff --git a/src/cares_wrap.cc b/src/cares_wrap.cc
@@ -257,7 +257,7 @@ class QueryWrap : public AsyncWrap {
       req_wrap_obj->Set(env->domain_string(), env->domain_array()->Get(0));
   }
 
-  virtual ~QueryWrap() override {
+  ~QueryWrap() override {
     CHECK_EQ(false, persistent().IsEmpty());
     ClearWrap(object());
     persistent().Reset();
diff --git a/src/fs_event_wrap.cc b/src/fs_event_wrap.cc
@@ -35,7 +35,7 @@ class FSEventWrap: public HandleWrap {
 
  private:
   FSEventWrap(Environment* env, Local<Object> object);
-  virtual ~FSEventWrap() override;
+  ~FSEventWrap() override;
 
   static void OnEvent(uv_fs_event_t* handle, const char* filename, int events,
     int status);
diff --git a/src/handle_wrap.h b/src/handle_wrap.h
@@ -55,7 +55,7 @@ class HandleWrap : public AsyncWrap {
              uv_handle_t* handle,
              AsyncWrap::ProviderType provider,
              AsyncWrap* parent = nullptr);
-  virtual ~HandleWrap() override;
+  ~HandleWrap() override;
 
  private:
   friend class Environment;
diff --git a/src/inspector_agent.cc b/src/inspector_agent.cc
@@ -240,18 +240,15 @@ class ChannelImpl final : public blink::protocol::FrontendChannel {
   explicit ChannelImpl(AgentImpl* agent): agent_(agent) {}
   virtual ~ChannelImpl() {}
  private:
-  virtual void sendProtocolResponse(int callId,
-                                    const String16& message)
-                                    override {
+  void sendProtocolResponse(int callId, const String16& message) override {
     sendMessageToFrontend(message);
   }
 
-  virtual void sendProtocolNotification(
-      const String16& message) override {
+  void sendProtocolNotification(const String16& message) override {
     sendMessageToFrontend(message);
   }
 
-  virtual void flushProtocolNotifications() override { }
+  void flushProtocolNotifications() override { }
 
   void sendMessageToFrontend(const String16& message) {
     agent_->Write(message.utf8());
diff --git a/src/node_stat_watcher.h b/src/node_stat_watcher.h
@@ -13,7 +13,7 @@ namespace node {
 
 class StatWatcher : public AsyncWrap {
  public:
-  virtual ~StatWatcher() override;
+  ~StatWatcher() override;
 
   static void Initialize(Environment* env, v8::Local<v8::Object> target);
 

Original file line number	Diff line number	Diff line change
`@@ -257,7 +257,7 @@ class QueryWrap : public AsyncWrap {`
`257`	`257`	`req_wrap_obj->Set(env->domain_string(), env->domain_array()->Get(0));`
`258`	`258`	`}`
`259`	`259`
`260`		`- virtual ~QueryWrap() override {`
	`260`	`+ ~QueryWrap() override {`
`261`	`261`	`CHECK_EQ(false, persistent().IsEmpty());`
`262`	`262`	`ClearWrap(object());`
`263`	`263`	`persistent().Reset();`