lib: fix stack overflow check to not break on primitives

kball · targos · commit 5f9ee9f69fe1 · 2019-07-02T11:46:58.000+02:00
PR-URL: #28338 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
diff --git a/lib/internal/errors.js b/lib/internal/errors.js
@@ -582,7 +582,7 @@ function isStackOverflowError(err) {
     }
   }
 
-  return err.name === maxStack_ErrorName &&
+  return err && err.name === maxStack_ErrorName &&
          err.message === maxStack_ErrorMessage;
 }
 
diff --git a/test/parallel/test-console-log-throw-primitive.js b/test/parallel/test-console-log-throw-primitive.js
@@ -0,0 +1,14 @@
+'use strict';
+require('../common');
+const { Writable } = require('stream');
+const { Console } = require('console');
+
+const stream = new Writable({
+  write() {
+    throw null; // eslint-disable-line no-throw-literal
+  }
+});
+
+const console = new Console({ stdout: stream });
+
+console.log('test'); // Should not throw

Original file line number	Diff line number	Diff line change
`@@ -582,7 +582,7 @@ function isStackOverflowError(err) {`
`582`	`582`	`}`
`583`	`583`	`}`
`584`	`584`
`585`		`- return err.name === maxStack_ErrorName &&`
	`585`	`+ return err && err.name === maxStack_ErrorName &&`
`586`	`586`	`err.message === maxStack_ErrorMessage;`
`587`	`587`	`}`
`588`	`588`