lib: add unsubscribe method to non-active DC channels

simon-id · danielleadams · commit 5e606b54b76f · 2022-01-29T16:32:08.000-05:00
PR-URL: #40433 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
diff --git a/doc/api/diagnostics_channel.md b/doc/api/diagnostics_channel.md
@@ -267,7 +267,7 @@ added:
 changes:
   - version: REPLACEME
     pr-url: https://github.com/nodejs/node/pull/40433
-    description: Added return value.
+    description: Added return value. Added to channels without subscribers.
 -->
 
 * `onMessage` {Function} The previous subscribed handler to remove
diff --git a/lib/diagnostics_channel.js b/lib/diagnostics_channel.js
@@ -81,6 +81,10 @@ class Channel {
     this.subscribe(subscription);
   }
 
+  unsubscribe() {
+    return false;
+  }
+
   get hasSubscribers() {
     return false;
   }

Original file line number	Diff line number	Diff line change
`@@ -81,6 +81,10 @@ class Channel {`
`81`	`81`	`this.subscribe(subscription);`
`82`	`82`	`}`
`83`	`83`
	`84`	`+ unsubscribe() {`
	`85`	`+ return false;`
	`86`	`+ }`
	`87`	`+`
`84`	`88`	`get hasSubscribers() {`
`85`	`89`	`return false;`
`86`	`90`	`}`