test: fixup failing test/internet/test-dns.js

jasnell · jasnell · commit 5e588c1c7c6e · 2021-04-16T18:45:28.000-07:00
The `ttl` for the `nodejs.org` DNS record is returning `0` currently. The test checks for `> 0`, causing the test to fail. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #38241 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/test/internet/test-dns.js b/test/internet/test-dns.js
@@ -91,7 +91,7 @@ TEST(async function test_resolve4_ttl(done) {
       assert.strictEqual(typeof item, 'object');
       assert.strictEqual(typeof item.ttl, 'number');
       assert.strictEqual(typeof item.address, 'string');
-      assert.ok(item.ttl > 0);
+      assert.ok(item.ttl >= 0);
       assert.ok(isIPv4(item.address));
     }
   }
@@ -119,7 +119,7 @@ TEST(async function test_resolve6_ttl(done) {
       assert.strictEqual(typeof item, 'object');
       assert.strictEqual(typeof item.ttl, 'number');
       assert.strictEqual(typeof item.address, 'string');
-      assert.ok(item.ttl > 0);
+      assert.ok(item.ttl >= 0);
       assert.ok(isIPv6(item.address));
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ TEST(async function test_resolve4_ttl(done) {`
`91`	`91`	`assert.strictEqual(typeof item, 'object');`
`92`	`92`	`assert.strictEqual(typeof item.ttl, 'number');`
`93`	`93`	`assert.strictEqual(typeof item.address, 'string');`
`94`		`- assert.ok(item.ttl > 0);`
	`94`	`+ assert.ok(item.ttl >= 0);`
`95`	`95`	`assert.ok(isIPv4(item.address));`
`96`	`96`	`}`
`97`	`97`	`}`
`@@ -119,7 +119,7 @@ TEST(async function test_resolve6_ttl(done) {`
`119`	`119`	`assert.strictEqual(typeof item, 'object');`
`120`	`120`	`assert.strictEqual(typeof item.ttl, 'number');`
`121`	`121`	`assert.strictEqual(typeof item.address, 'string');`
`122`		`- assert.ok(item.ttl > 0);`
	`122`	`+ assert.ok(item.ttl >= 0);`
`123`	`123`	`assert.ok(isIPv6(item.address));`
`124`	`124`	`}`
`125`	`125`	`}`