util: remove style caches from styleText slow path

araujogui · araujogui · commit 5dc48c3bcd82 · 2026-06-01T18:47:07.000-03:00
diff --git a/lib/util.js b/lib/util.js
@@ -241,10 +241,10 @@ function rgbToAnsi24Bit(r, g, b) {
  */
 function styleText(format, text, options) {
   const validateStream = options?.validateStream ?? true;
-  const cache = getStyleCache();
 
   // Fast path: single format string with validateStream=false
   if (!validateStream && typeof format === 'string' && typeof text === 'string') {
+    const cache = getStyleCache();
     if (format === 'none') return text;
     const style = cache[format];
     if (style !== undefined) {
@@ -284,6 +284,7 @@ function styleText(format, text, options) {
   }
 
   const formatArray = ArrayIsArray(format) ? format : [format];
+  const colors = inspect.colors;
 
   let openCodes = '';
   let closeCodes = '';
@@ -293,30 +294,29 @@ function styleText(format, text, options) {
     if (key === 'none') continue;
 
     if (typeof key === 'string' && key[0] === '#') {
-      let hexStyle = getHexStyleCache().get(key);
-      if (hexStyle === undefined) {
-        if (RegExpPrototypeExec(hexColorRegExp, key) === null) {
-          throw new ERR_INVALID_ARG_VALUE('format', key,
-                                          'must be a valid hex color (#RGB or #RRGGBB)');
-        }
-        if (skipColorize) continue;
-        hexStyle = getHexStyle(key);
-      } else if (skipColorize) {
-        continue;
+      if (RegExpPrototypeExec(hexColorRegExp, key) === null) {
+        throw new ERR_INVALID_ARG_VALUE('format', key,
+                                        'must be a valid hex color (#RGB or #RRGGBB)');
       }
-      openCodes += hexStyle.openSeq;
-      closeCodes = hexStyle.closeSeq + closeCodes;
-      processedText = replaceCloseCode(processedText, hexStyle.closeSeq, hexStyle.openSeq, false);
+      if (skipColorize) continue;
+      const { 0: r, 1: g, 2: b } = hexToRgb(key);
+      const hexOpenSeq = kEscape + rgbToAnsi24Bit(r, g, b) + kEscapeEnd;
+      openCodes += hexOpenSeq;
+      closeCodes = kHexCloseSeq + closeCodes;
+      processedText = replaceCloseCode(processedText, kHexCloseSeq, hexOpenSeq, false);
       continue;
     }
 
-    const style = cache[key];
-    if (style === undefined) {
+    const codes = colors[key];
+    if (codes === undefined) {
       validateOneOf(key, 'format', ObjectGetOwnPropertyNames(inspect.colors));
     }
-    openCodes += style.openSeq;
-    closeCodes = style.closeSeq + closeCodes;
-    processedText = replaceCloseCode(processedText, style.closeSeq, style.openSeq, style.keepClose);
+    const openSeq = kEscape + codes[0] + kEscapeEnd;
+    const closeSeq = kEscape + codes[1] + kEscapeEnd;
+    const keepClose = codes[0] === kDimCode || codes[0] === kBoldCode;
+    openCodes += openSeq;
+    closeCodes = closeSeq + closeCodes;
+    processedText = replaceCloseCode(processedText, closeSeq, openSeq, keepClose);
   }
 
   if (skipColorize) return text;
