src: fix integer overflow in GetNow

apapirovski · targos · commit 5b7419bc4c21 · 2018-08-12T11:45:35.000+02:00
PR-URL: #22214 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Matheus Marchini <matheus@sthima.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
diff --git a/src/env.cc b/src/env.cc
@@ -536,7 +536,7 @@ Local<Value> Environment::GetNow() {
   CHECK_GE(now, timer_base());
   now -= timer_base();
   if (now <= 0xffffffff)
-    return Integer::New(isolate(), static_cast<uint32_t>(now));
+    return Integer::NewFromUnsigned(isolate(), static_cast<uint32_t>(now));
   else
     return Number::New(isolate(), static_cast<double>(now));
 }

Original file line number	Diff line number	Diff line change
`@@ -536,7 +536,7 @@ Local<Value> Environment::GetNow() {`
`536`	`536`	`CHECK_GE(now, timer_base());`
`537`	`537`	`now -= timer_base();`
`538`	`538`	`if (now <= 0xffffffff)`
`539`		`- return Integer::New(isolate(), static_cast<uint32_t>(now));`
	`539`	`+ return Integer::NewFromUnsigned(isolate(), static_cast<uint32_t>(now));`
`540`	`540`	`else`
`541`	`541`	`return Number::New(isolate(), static_cast<double>(now));`
`542`	`542`	`}`