test: add more coverage to node_config_file

marco-ippolito · targos · commit 5a21fa4573aa · 2025-03-11T19:37:55.000+01:00
PR-URL: #57170 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
diff --git a/test/fixtures/rc/broken-node-options.json b/test/fixtures/rc/broken-node-options.json
@@ -0,0 +1,5 @@
+{
+    "nodeOptions": {
+        "inspect-port
+    }
+}
diff --git a/test/fixtures/rc/broken.json b/test/fixtures/rc/broken.json
@@ -0,0 +1 @@
+{
diff --git a/test/fixtures/rc/non-object-node-options.json b/test/fixtures/rc/non-object-node-options.json
@@ -0,0 +1,3 @@
+{
+  "nodeOptions": "string"
+}
diff --git a/test/fixtures/rc/non-object-root.json b/test/fixtures/rc/non-object-root.json
@@ -0,0 +1 @@
+[]
diff --git a/test/parallel/test-config-file.js b/test/parallel/test-config-file.js
@@ -254,3 +254,53 @@ test('should not allow users to sneak in a flag', async () => {
   strictEqual(result.stdout, '');
   strictEqual(result.code, 9);
 });
+
+test('non object root', async () => {
+  const result = await spawnPromisified(process.execPath, [
+    '--no-warnings',
+    '--experimental-config-file',
+    fixtures.path('rc/non-object-root.json'),
+    '-p', '"Hello, World!"',
+  ]);
+  match(result.stderr, /Root value unexpected not an object for/);
+  strictEqual(result.stdout, '');
+  strictEqual(result.code, 9);
+});
+
+test('non object node options', async () => {
+  const result = await spawnPromisified(process.execPath, [
+    '--no-warnings',
+    '--experimental-config-file',
+    fixtures.path('rc/non-object-node-options.json'),
+    '-p', '"Hello, World!"',
+  ]);
+  match(result.stderr, /"nodeOptions" value unexpected for/);
+  strictEqual(result.stdout, '');
+  strictEqual(result.code, 9);
+});
+
+test('should throw correct error when a json is broken', async () => {
+  const result = await spawnPromisified(process.execPath, [
+    '--no-warnings',
+    '--experimental-config-file',
+    fixtures.path('rc/broken.json'),
+    '-p', '"Hello, World!"',
+  ]);
+  match(result.stderr, /Can't parse/);
+  match(result.stderr, /broken\.json: invalid content/);
+  strictEqual(result.stdout, '');
+  strictEqual(result.code, 9);
+});
+
+test('broken value in node_options', async () => {
+  const result = await spawnPromisified(process.execPath, [
+    '--no-warnings',
+    '--experimental-config-file',
+    fixtures.path('rc/broken-node-options.json'),
+    '-p', '"Hello, World!"',
+  ]);
+  match(result.stderr, /Can't parse/);
+  match(result.stderr, /broken-node-options\.json: invalid content/);
+  strictEqual(result.stdout, '');
+  strictEqual(result.code, 9);
+});

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +{
 +    "nodeOptions": {
 +        "inspect-port
 +    }
 +}
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+{`
	`2`	`+ "nodeOptions": "string"`
	`3`	`+}`