sqlite: isolate applyChangeset filter errors · nodejs/node@59827ac · GitHub
Skip to content

Commit 59827ac

Browse files
trivikraduh95
authored andcommitted
sqlite: isolate applyChangeset filter errors
Track filter callback failures within each applyChangeset() invocation. Returning false from xFilter is not a SQLite error. This previously left the database-wide suppression flag set, which could hide the next unrelated SQLite error. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol PR-URL: #64823 Fixes: #64822 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
1 parent 5a01df2 commit 59827ac

2 files changed

Lines changed: 13 additions & 5 deletions

File tree

‎src/node_sqlite.cc‎

Lines changed: 6 additions & 5 deletions

‎test/parallel/test-sqlite-session.js‎

Lines changed: 7 additions & 0 deletions

0 commit comments

Comments
 (0)