http: replace startsWith with strict equality

btea · aduh95 · commit 5703ce68bc70 · 2025-11-13T22:44:15.000+01:00
PR-URL: #59394 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
diff --git a/lib/internal/http.js b/lib/internal/http.js
@@ -156,7 +156,7 @@ class ProxyConfig {
       if (entry === host || entry === hostWithPort) return false;  // Matching host and host:port
 
       // Follow curl's behavior: strip leading dot before matching suffixes.
-      if (entry.startsWith('.')) {
+      if (entry[0] === '.') {
         const suffix = entry.substring(1);
         if (host.endsWith(suffix)) return false;
       }

Original file line number	Diff line number	Diff line change
`@@ -156,7 +156,7 @@ class ProxyConfig {`
`156`	`156`	`if (entry === host \|\| entry === hostWithPort) return false; // Matching host and host:port`
`157`	`157`
`158`	`158`	`// Follow curl's behavior: strip leading dot before matching suffixes.`
`159`		`- if (entry.startsWith('.')) {`
	`159`	`+ if (entry[0] === '.') {`
`160`	`160`	`const suffix = entry.substring(1);`
`161`	`161`	`if (host.endsWith(suffix)) return false;`
`162`	`162`	`}`