worker: add Symbol.toStringTag to MessageChannel and MessagePort · nodejs/node@56e6a5c · GitHub
Skip to content

Commit 56e6a5c

Browse files
lazergaduh95
authored andcommitted
worker: add Symbol.toStringTag to MessageChannel and MessagePort
Signed-off-by: Lazizbek Ergashev <lazerg2@gmail.com> PR-URL: #65532 Fixes: #65527 Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 62187ab commit 56e6a5c

4 files changed

Lines changed: 33 additions & 3 deletions

File tree

‎lib/internal/worker/io.js‎

Lines changed: 13 additions & 0 deletions

‎test/parallel/test-eventtarget-memoryleakwarning.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,12 @@ common.expectWarning({
1515
'EventTarget. MaxListeners is 2. Use events.setMaxListeners() ' +
1616
'to increase limit'],
1717
['Possible EventTarget memory leak detected. 3 foo listeners added to ' +
18-
'[MessagePort [EventTarget]]. ' +
18+
'[MessagePort]. ' +
1919
'MaxListeners is 2. ' +
2020
'Use events.setMaxListeners() to increase ' +
2121
'limit'],
2222
['Possible EventTarget memory leak detected. 3 foo listeners added to ' +
23-
'[MessagePort [EventTarget]]. ' +
23+
'[MessagePort]. ' +
2424
'MaxListeners is 2. ' +
2525
'Use events.setMaxListeners() to increase ' +
2626
'limit'],
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
'use strict';
2+
3+
require('../common');
4+
5+
const assert = require('assert');
6+
7+
const classesToBeTested = [ MessageChannel, MessagePort ];
8+
9+
classesToBeTested.forEach((cls) => {
10+
assert.strictEqual(cls.prototype[Symbol.toStringTag], cls.name);
11+
assert.deepStrictEqual(Object.getOwnPropertyDescriptor(cls.prototype, Symbol.toStringTag),
12+
{ configurable: true, enumerable: false, value: cls.name, writable: false });
13+
});
14+
15+
const channel = new MessageChannel();
16+
assert.strictEqual(Object.prototype.toString.call(channel), '[object MessageChannel]');
17+
assert.strictEqual(Object.prototype.toString.call(channel.port1), '[object MessagePort]');

‎test/parallel/test-worker-message-port-inspect-during-init-hook.js‎

Lines changed: 1 addition & 1 deletion

0 commit comments

Comments
 (0)