benchmark: apply `highWaterMark` in webstreams `pipe-to` · nodejs/node@562168f · GitHub
Skip to content

Commit 562168f

Browse files
mcollinaaduh95
authored andcommitted
benchmark: apply highWaterMark in webstreams pipe-to
The highWaterMark values were passed as properties of the underlying source and sink dictionaries, where they are ignored: a queuing strategy's highWaterMark is read from the constructors' second argument. Every configuration therefore measured the identical workload at the default highWaterMark of 1, which also explains the historically high run-to-run variance of this benchmark family. Pass the strategies as the constructors' second argument and cover the default (1) alongside buffered (1024, 4096) configurations. Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #65138 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
1 parent 5edffb5 commit 562168f

1 file changed

Lines changed: 4 additions & 6 deletions

File tree

benchmark/webstreams/pipe-to.js

Lines changed: 4 additions & 6 deletions

0 commit comments

Comments
 (0)