build: enable the V8 sandbox in shared-cage builds · nodejs/node@55213fd · GitHub
Skip to content

Commit 55213fd

Browse files
codebytereaduh95
authored andcommitted
build: enable the V8 sandbox in shared-cage builds
V8 defaults `v8_enable_sandbox` to on whenever the shared pointer compression cage and the external code space are enabled, and that is the configuration embedders that use the sandbox build with. Now that the sandbox builds and passes the tests, follow that default for `--experimental-pointer-compression-shared-cage` so the configuration is reachable from `configure`. Multi-cage pointer compression builds stay without it: there every IsolateGroup gets its own sandbox, and `NodeArrayBufferAllocator` always allocates from the default one. Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com> PR-URL: #62237 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
1 parent 855fff6 commit 55213fd

1 file changed

Lines changed: 5 additions & 11 deletions

File tree

‎configure.py‎

Lines changed: 5 additions & 11 deletions

0 commit comments

Comments
 (0)