test: replace flaky pummel regression tests · nodejs/node@54a4c6a · GitHub
Skip to content

Commit 54a4c6a

Browse files
addaleaxcodebytere
authored andcommitted
test: replace flaky pummel regression tests
These tests were written a long time ago, and use the allocation of large amounts of unused memory as a way to detect use-after-free problems with Buffers. As a result, the tests are resource-intensive and may crash because of that. Replace them with a more modern test. We don’t explicitly try to *detect* use-after-free conditions, and instead rely on e.g. ASAN (or the process just crashing hard) to do that for us. Fixes: #34527 PR-URL: #34530 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
1 parent 12cb0fb commit 54a4c6a

3 files changed

Lines changed: 39 additions & 195 deletions

File tree

Lines changed: 39 additions & 0 deletions

test/pummel/test-regress-GH-814.js

Lines changed: 0 additions & 90 deletions
This file was deleted.

test/pummel/test-regress-GH-814_2.js

Lines changed: 0 additions & 105 deletions
This file was deleted.

0 commit comments

Comments
 (0)