perf_hooks: fix loop delay resolution validation

aduh95 · Flarna · commit 548cbf0625cd · 2021-04-11T23:15:47.000+02:00
Fixes: #38160 PR-URL: #38166 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/src/node_perf.cc b/src/node_perf.cc
@@ -237,7 +237,7 @@ void LoopIdleTime(const FunctionCallbackInfo<Value>& args) {
 void ELDHistogram::New(const FunctionCallbackInfo<Value>& args) {
   Environment* env = Environment::GetCurrent(args);
   CHECK(args.IsConstructCall());
-  int32_t resolution = args[0].As<Int32>()->Value();
+  int64_t resolution = args[0].As<Integer>()->Value();
   CHECK_GT(resolution, 0);
   new ELDHistogram(env, args.This(), resolution);
 }
@@ -253,7 +253,7 @@ void ELDHistogram::Initialize(Environment* env, Local<Object> target) {
 ELDHistogram::ELDHistogram(
     Environment* env,
     Local<Object> wrap,
-    int32_t interval)
+    int64_t interval)
     : IntervalHistogram(
           env,
           wrap,
diff --git a/src/node_perf.h b/src/node_perf.h
@@ -166,7 +166,7 @@ class ELDHistogram : public IntervalHistogram {
   ELDHistogram(
       Environment* env,
       v8::Local<v8::Object> wrap,
-      int32_t interval);
+      int64_t interval);
 
   void OnInterval() override;
 
diff --git a/test/sequential/test-performance-eventloopdelay.js b/test/sequential/test-performance-eventloopdelay.js
@@ -39,7 +39,7 @@ const { sleep } = require('internal/util');
     );
   });
 
-  [-1, 0, Infinity].forEach((i) => {
+  [-1, 0, 2 ** 53, Infinity].forEach((i) => {
     assert.throws(
       () => monitorEventLoopDelay({ resolution: i }),
       {

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ const { sleep } = require('internal/util');`
`39`	`39`	`);`
`40`	`40`	`});`
`41`	`41`
`42`		`- [-1, 0, Infinity].forEach((i) => {`
	`42`	`+ [-1, 0, 2 ** 53, Infinity].forEach((i) => {`
`43`	`43`	`assert.throws(`
`44`	`44`	`() => monitorEventLoopDelay({ resolution: i }),`
`45`	`45`	`{`