test: fix missing edge case in test-blob-slice-with-large-size

joyeecheung · targos · commit 53cb29898bc8 · 2025-05-31T13:25:46.000+02:00
The test only cares about whether a size outside the range of the 32-bit signed integers works with Blob.prototype.slice(). If it fails due to allocation failure when the system does not have enough memory, the test should just be skipped. The test previously only skipped the test when the allocation failure happens during allocation of the buffer source, but it could also happen during Blob.prototype.slice(). PR-URL: #58414 Fixes: #57235 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
diff --git a/test/pummel/test-blob-slice-with-large-size.js b/test/pummel/test-blob-slice-with-large-size.js
@@ -1,4 +1,7 @@
 'use strict';
+
+// This tests that Blob.prototype.slice() works correctly when the size of the
+// Blob is outside the range of 32-bit signed integers.
 const common = require('../common');
 
 // Buffer with size > INT32_MAX
@@ -14,8 +17,11 @@ try {
   const slicedBlob = blob.slice(size - 1, size);
   assert.strictEqual(slicedBlob.size, 1);
 } catch (e) {
-  if (e.code !== 'ERR_MEMORY_ALLOCATION_FAILED') {
-    throw e;
+  if (e.code === 'ERR_MEMORY_ALLOCATION_FAILED') {
+    common.skip('insufficient space for Buffer.allocUnsafe');
+  }
+  if (/Array buffer allocation failed/.test(e.message)) {
+    common.skip('insufficient space for Blob.prototype.slice()');
   }
-  common.skip('insufficient space for Buffer.allocUnsafe');
+  throw e;
 }
