test: deflake inspector network fetch · nodejs/node@5345613 · GitHub
Skip to content

Commit 5345613

Browse files
panvaaduh95
authored andcommitted
test: deflake inspector network fetch
A Windows socket bound to 127.0.0.1 can accept connections intended for another process's wildcard listener on the same port. A competing inspector can then answer the HTTP request with 400 or send plaintext to the HTTPS client. Bind both fixture servers to the address used by their requests to prevent the competing bind. Bypass environment proxies so local HTTP and HTTPS requests reach the fixture servers directly, and remove the Windows flaky expectation. Fixes: #59090 Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Claude, Codex PR-URL: #66320 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
1 parent 25c08fc commit 5345613

2 files changed

Lines changed: 6 additions & 5 deletions

File tree

‎test/parallel/parallel.status‎

Lines changed: 0 additions & 2 deletions

‎test/parallel/test-inspector-network-fetch.js‎

Lines changed: 6 additions & 3 deletions

0 commit comments

Comments
 (0)