deps: V8: cherry-pick f915fa4c9f41 · nodejs/node@52d3944 · GitHub
Skip to content

Commit 52d3944

Browse files
o-targos
authored andcommitted
deps: V8: cherry-pick f915fa4c9f41
Original commit message: [osr] Ensure trying to osr does not skip loop interrupts Fixed: 374013413 Change-Id: I52d7b4e165e0abd0bd517a81d2e8ef3f1f802bfb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5946288 Commit-Queue: Darius Mercadier <dmercadier@chromium.org> Auto-Submit: Olivier Flückiger <olivf@chromium.org> Reviewed-by: Darius Mercadier <dmercadier@chromium.org> Cr-Commit-Position: refs/heads/main@{#96708} Refs: v8/v8@f915fa4 PR-URL: #55014 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
1 parent 99ffe35 commit 52d3944

3 files changed

Lines changed: 24 additions & 2 deletions

File tree

common.gypi

Lines changed: 1 addition & 1 deletion

deps/v8/src/codegen/compiler.cc

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1338,7 +1338,14 @@ MaybeHandle<Code> GetOrCompileOptimized(
13381338
}
13391339

13401340
// Do not optimize when debugger needs to hook into every call.
1341-
if (isolate->debug()->needs_check_on_function_call()) return {};
1341+
if (isolate->debug()->needs_check_on_function_call()) {
1342+
// Reset the OSR urgency to avoid triggering this compilation request on
1343+
// every iteration and thereby skipping other interrupts.
1344+
if (IsOSR(osr_offset)) {
1345+
function->feedback_vector()->reset_osr_urgency();
1346+
}
1347+
return {};
1348+
}
13421349

13431350
// Do not optimize if we need to be able to set break points.
13441351
if (shared->HasBreakInfo(isolate)) return {};
Lines changed: 15 additions & 0 deletions

0 commit comments

Comments
 (0)