src: update NODE_MODULE_VERSION to 91

targos · targos · commit 5259d1730933 · 2021-02-11T19:09:29.000+01:00
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 8.8. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md PR-URL: #36139 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>
diff --git a/doc/abi_version_registry.json b/doc/abi_version_registry.json
@@ -1,5 +1,6 @@
 {
   "NODE_MODULE_VERSION": [
+    { "modules": 91, "runtime": "node",     "variant": "v8_8.8",               "versions": "16.0.0-pre" },
     { "modules": 90, "runtime": "node",     "variant": "v8_8.7",               "versions": "16.0.0-pre" },
     { "modules": 89, "runtime": "electron", "variant": "electron",             "versions": "13" },
     { "modules": 88, "runtime": "node",     "variant": "v8_8.6",               "versions": "15.0.0" },
diff --git a/src/node_version.h b/src/node_version.h
@@ -89,7 +89,7 @@
  * version matching should open a pull request to reserve a number in this
  * registry.
  */
-#define NODE_MODULE_VERSION 89
+#define NODE_MODULE_VERSION 91
 
 // The NAPI_VERSION provided by this version of the runtime. This is the version
 // which the Node binary being built supports.

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"NODE_MODULE_VERSION": [`
	`3`	`+ { "modules": 91, "runtime": "node", "variant": "v8_8.8", "versions": "16.0.0-pre" },`
`3`	`4`	`{ "modules": 90, "runtime": "node", "variant": "v8_8.7", "versions": "16.0.0-pre" },`
`4`	`5`	`{ "modules": 89, "runtime": "electron", "variant": "electron", "versions": "13" },`
`5`	`6`	`{ "modules": 88, "runtime": "node", "variant": "v8_8.6", "versions": "15.0.0" },`