doc: update FreeEnvironment() notes for sibling Environments · nodejs/node@510dfd8 · GitHub
Skip to content

Commit 510dfd8

Browse files
codebytereaduh95
authored andcommitted
doc: update FreeEnvironment() notes for sibling Environments
With the FreeEnvironment() fix for sibling Environments and the handle cleanup depth tracked per thread, only the Environment being freed loses JavaScript while FreeEnvironment() runs the shared loop. Callbacks of the other Environments on that loop run their JavaScript as usual. Update embedding.md and the comment in node.h, which still describe JavaScript as disallowed on the whole isolate. Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com> PR-URL: #66239 Refs: #65977 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
1 parent aead8a9 commit 510dfd8

2 files changed

Lines changed: 6 additions & 9 deletions

File tree

‎doc/api/embedding.md‎

Lines changed: 4 additions & 7 deletions

‎src/node.h‎

Lines changed: 2 additions & 2 deletions

0 commit comments

Comments
 (0)