test: deflake watch cwd with isolation none · nodejs/node@4da36cb · GitHub
Skip to content

Commit 4da36cb

Browse files
panvaaduh95
authored andcommitted
test: deflake watch cwd with isolation none
Windows directory watchers report last-access time updates. Reading cold fixtures in the child can therefore trigger test:watch:restarted before it exits, failing the mustNotCall assertion without printing the error. Read the fixtures before starting watch mode and remove the Windows flaky expectation. With old access times and a delayed child exit, the original fails 10/10 runs and the change passes 100/100 on Windows. Also remove the argv variant's stale flaky expectation. It passes repeated local Windows runs and the inspected CI history after #66035. Refs: #66056 Refs: #66035 Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex PR-URL: #66320 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
1 parent c3041c1 commit 4da36cb

2 files changed

Lines changed: 7 additions & 6 deletions

File tree

‎test/test-runner/test-run-watch-cwd-isolation-none.mjs‎

Lines changed: 7 additions & 1 deletion

‎test/test-runner/test-runner.status‎

Lines changed: 0 additions & 5 deletions

0 commit comments

Comments
 (0)