fs: make mutating options in Callback readdir() not affect results

LiviaMedeiros · aduh95 · commit 4cc0493a0b14 · 2024-12-18T22:31:02.000+01:00
PR-URL: #56057 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/lib/fs.js b/lib/fs.js
@@ -1530,6 +1530,9 @@ function readdir(path, options, callback) {
   }
 
   if (options.recursive) {
+    // Make shallow copy to prevent mutating options from affecting results
+    options = copyObject(options);
+
     readdirRecursive(path, options, callback);
     return;
   }
diff --git a/test/parallel/test-fs-readdir-types.js b/test/parallel/test-fs-readdir-types.js
@@ -86,6 +86,14 @@ fs.readdir(readdirDir, {
   assertDirents(await direntsPromise);
 })().then(common.mustCall());
 
+{
+  const options = { recursive: true, withFileTypes: true };
+  fs.readdir(readdirDir, options, common.mustSucceed((dirents) => {
+    assertDirents(dirents);
+  }));
+  options.withFileTypes = false;
+}
+
 // Check for correct types when the binding returns unknowns
 const UNKNOWN = constants.UV_DIRENT_UNKNOWN;
 const oldReaddir = binding.readdir;

Original file line number	Diff line number	Diff line change
`@@ -1530,6 +1530,9 @@ function readdir(path, options, callback) {`
`1530`	`1530`	`}`
`1531`	`1531`
`1532`	`1532`	`if (options.recursive) {`
	`1533`	`+ // Make shallow copy to prevent mutating options from affecting results`
	`1534`	`+ options = copyObject(options);`
	`1535`	`+`
`1533`	`1536`	`readdirRecursive(path, options, callback);`
`1534`	`1537`	`return;`
`1535`	`1538`	`}`