test: deflake node-api test-free-called · nodejs/node@4c702e4 · GitHub
Skip to content

Commit 4c702e4

Browse files
christianaurichzmaduh95
authored andcommitted
test: deflake node-api test-free-called
`node-api/test_worker_buffer_callback/test-free-called` checks that `getFreeCallCount()` is 0 on a line that runs after `new Worker()`. The worker thread can load the addon and run its finalizer before the main thread reaches that line, in which case the counter is already 1 and the assertion fails. The zero check is only a baseline, so it does not need the worker to exist. Move it above the worker creation. The equivalent test under test/addons/worker-buffer-callback was changed the same way in 64f7d0e. Signed-off-by: Christian Aurich <christian.aurichzm@gmail.com> PR-URL: #65948 Refs: #51013 Refs: https://github.com/nodejs/reliability/blob/e457f5b68957d1502256488977bc33b4346d8a4b/reports/2026-09-10.md Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
1 parent 21aec3f commit 4c702e4

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

‎test/node-api/test_worker_buffer_callback/test-free-called.js‎

Lines changed: 2 additions & 1 deletion

0 commit comments

Comments
 (0)