src: add support for ETW stack walking

jdapena · ruyadorno · commit 4c59b60ee88e · 2023-01-31T18:16:08.000-05:00
V8 supports native stack walking in Windows by providing JIT code information to ETW (Event Tracing for Windows). But the option to enable it is not exposed in NodeJS. Just add command line (and environment variable) support for --enable-etw-stack-walking, that maps to V8 option of the same name. Fixes: #46202 PR-URL: #46203 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
diff --git a/doc/api/cli.md b/doc/api/cli.md
@@ -1970,6 +1970,7 @@ V8 options that are allowed are:
 
 * `--abort-on-uncaught-exception`
 * `--disallow-code-generation-from-strings`
+* `--enable-etw-stack-walking`
 * `--huge-max-old-generation-size`
 * `--interpreted-frames-native-stack`
 * `--jitless`
@@ -1986,6 +1987,8 @@ V8 options that are allowed are:
 `--perf-basic-prof-only-functions`, `--perf-basic-prof`,
 `--perf-prof-unwinding-info`, and `--perf-prof` are only available on Linux.
 
+`--enable-etw-stack-walking` is only available on Windows.
+
 ### `NODE_PATH=path[:&hellip;]`
 
 <!-- YAML
diff --git a/src/node_options.cc b/src/node_options.cc
@@ -752,6 +752,10 @@ PerIsolateOptionsParser::PerIsolateOptionsParser(
             &PerIsolateOptions::report_signal,
             kAllowedInEnvvar);
   Implies("--report-signal", "--report-on-signal");
+  AddOption("--enable-etw-stack-walking",
+            "provides heap data to ETW Windows native tracing",
+            V8Option{},
+            kAllowedInEnvvar);
 
   AddOption("--experimental-top-level-await", "", NoOp{}, kAllowedInEnvvar);
 
