stream: improve inspector ergonomics

benjamingr · aduh95 · commit 4bf62f6cbdb4 · 2024-07-16T12:01:20.000+02:00
PR-URL: #53800 Fixes: #53789 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
diff --git a/lib/internal/webstreams/readablestream.js b/lib/internal/webstreams/readablestream.js
@@ -2041,8 +2041,8 @@ function readableStreamError(stream, error) {
   assert(stream[kState].state === 'readable');
   stream[kState].state = 'errored';
   stream[kState].storedError = error;
-  stream[kIsClosedPromise].reject(error);
   setPromiseHandled(stream[kIsClosedPromise].promise);
+  stream[kIsClosedPromise].reject(error);
 
   const {
     reader,
@@ -2051,8 +2051,8 @@ function readableStreamError(stream, error) {
   if (reader === undefined)
     return;
 
-  reader[kState].close.reject(error);
   setPromiseHandled(reader[kState].close.promise);
+  reader[kState].close.reject(error);
 
   if (readableStreamHasDefaultReader(stream)) {
     for (let n = 0; n < reader[kState].readRequests.length; n++)
diff --git a/lib/internal/webstreams/writablestream.js b/lib/internal/webstreams/writablestream.js
@@ -768,15 +768,15 @@ function writableStreamRejectCloseAndClosedPromiseIfNeeded(stream) {
     };
   }
 
-  stream[kIsClosedPromise].reject(stream[kState]?.storedError);
   setPromiseHandled(stream[kIsClosedPromise].promise);
+  stream[kIsClosedPromise].reject(stream[kState]?.storedError);
 
   const {
     writer,
   } = stream[kState];
   if (writer !== undefined) {
-    writer[kState].close.reject?.(stream[kState].storedError);
     setPromiseHandled(writer[kState].close.promise);
+    writer[kState].close.reject?.(stream[kState].storedError);
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -768,15 +768,15 @@ function writableStreamRejectCloseAndClosedPromiseIfNeeded(stream) {`
`768`	`768`	`};`
`769`	`769`	`}`
`770`	`770`
`771`		`- stream[kIsClosedPromise].reject(stream[kState]?.storedError);`
`772`	`771`	`setPromiseHandled(stream[kIsClosedPromise].promise);`
	`772`	`+ stream[kIsClosedPromise].reject(stream[kState]?.storedError);`
`773`	`773`
`774`	`774`	`const {`
`775`	`775`	`writer,`
`776`	`776`	`} = stream[kState];`
`777`	`777`	`if (writer !== undefined) {`
`778`		`- writer[kState].close.reject?.(stream[kState].storedError);`
`779`	`778`	`setPromiseHandled(writer[kState].close.promise);`
	`779`	`+ writer[kState].close.reject?.(stream[kState].storedError);`
`780`	`780`	`}`
`781`	`781`	`}`
`782`	`782`