dns: fix parse memory leaky

theanarkh · aduh95 · commit 4baf2167e7b3 · 2025-07-27T20:28:13.000+02:00
PR-URL: #58973 Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/src/cares_wrap.cc b/src/cares_wrap.cc
@@ -1565,6 +1565,8 @@ Maybe<int> SoaTraits::Parse(QuerySoaWrap* wrap,
 
   if (status != ARES_SUCCESS) return Just<int>(status);
 
+  auto cleanup = OnScopeLeave([&]() { ares_free_data(soa_out); });
+
   Local<Object> soa_record = Object::New(env->isolate());
 
   if (soa_record
@@ -1605,8 +1607,6 @@ Maybe<int> SoaTraits::Parse(QuerySoaWrap* wrap,
     return Nothing<int>();
   }
 
-  ares_free_data(soa_out);
-
   wrap->CallOnComplete(soa_record);
   return Just<int>(ARES_SUCCESS);
 }

Original file line number	Diff line number	Diff line change
`@@ -1565,6 +1565,8 @@ Maybe<int> SoaTraits::Parse(QuerySoaWrap* wrap,`
`1565`	`1565`
`1566`	`1566`	`if (status != ARES_SUCCESS) return Just<int>(status);`
`1567`	`1567`
	`1568`	`+ auto cleanup = OnScopeLeave([&]() { ares_free_data(soa_out); });`
	`1569`	`+`
`1568`	`1570`	`Local<Object> soa_record = Object::New(env->isolate());`
`1569`	`1571`
`1570`	`1572`	`if (soa_record`
`@@ -1605,8 +1607,6 @@ Maybe<int> SoaTraits::Parse(QuerySoaWrap* wrap,`
`1605`	`1607`	`return Nothing<int>();`
`1606`	`1608`	`}`
`1607`	`1609`
`1608`		`- ares_free_data(soa_out);`
`1609`		`-`
`1610`	`1610`	`wrap->CallOnComplete(soa_record);`
`1611`	`1611`	`return Just<int>(ARES_SUCCESS);`
`1612`	`1612`	`}`