zlib: remove unused parameters

MaleDong · rvagg · commit 4b0d2de5f470 · 2018-08-15T20:23:17.000+10:00
When `checkRangesOrGetDefault` calls `checkFiniteNumber`, the latter function only has two parameters, so `lower` and `upper` don't need to be passed for validation. PR-URL: #22115 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
diff --git a/lib/zlib.js b/lib/zlib.js
@@ -198,12 +198,12 @@ function checkFiniteNumber(number, name) {
   throw err;
 }
 
-// 1. Returns def for undefined and NaN
+// 1. Returns def for number when it's undefined or NaN
 // 2. Returns number for finite numbers >= lower and <= upper
 // 3. Throws ERR_INVALID_ARG_TYPE for non-numbers
 // 4. Throws ERR_OUT_OF_RANGE for infinite numbers or numbers > upper or < lower
 function checkRangesOrGetDefault(number, name, lower, upper, def) {
-  if (!checkFiniteNumber(number, name, lower, upper)) {
+  if (!checkFiniteNumber(number, name)) {
     return def;
   }
   if (number < lower || number > upper) {

Original file line number	Diff line number	Diff line change
`@@ -198,12 +198,12 @@ function checkFiniteNumber(number, name) {`
`198`	`198`	`throw err;`
`199`	`199`	`}`
`200`	`200`
`201`		`-// 1. Returns def for undefined and NaN`
	`201`	`+// 1. Returns def for number when it's undefined or NaN`
`202`	`202`	`// 2. Returns number for finite numbers >= lower and <= upper`
`203`	`203`	`// 3. Throws ERR_INVALID_ARG_TYPE for non-numbers`
`204`	`204`	`// 4. Throws ERR_OUT_OF_RANGE for infinite numbers or numbers > upper or < lower`
`205`	`205`	`function checkRangesOrGetDefault(number, name, lower, upper, def) {`
`206`		`- if (!checkFiniteNumber(number, name, lower, upper)) {`
	`206`	`+ if (!checkFiniteNumber(number, name)) {`
`207`	`207`	`return def;`
`208`	`208`	`}`
`209`	`209`	`if (number < lower \|\| number > upper) {`