net: validate non-string host for socket.connect

daeyeon · targos · commit 4762f4ada5c0 · 2025-03-11T19:42:08.000+01:00
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: #57198 Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/lib/net.js b/lib/net.js
@@ -1311,6 +1311,8 @@ function lookupAndConnect(self, options) {
   const host = options.host || 'localhost';
   let { port, autoSelectFamilyAttemptTimeout, autoSelectFamily } = options;
 
+  validateString(host, 'options.host');
+
   if (localAddress && !isIP(localAddress)) {
     throw new ERR_INVALID_IP_ADDRESS(localAddress);
   }
diff --git a/test/parallel/test-net-connect-options-invalid.js b/test/parallel/test-net-connect-options-invalid.js
@@ -25,3 +25,15 @@ const net = require('net');
     });
   });
 }
+
+{
+  assert.throws(() => {
+    net.createConnection({
+      host: ['192.168.0.1'],
+      port: 8080,
+    });
+  }, {
+    code: 'ERR_INVALID_ARG_TYPE',
+    name: 'TypeError',
+  });
+}

Original file line number	Diff line number	Diff line change
`@@ -1311,6 +1311,8 @@ function lookupAndConnect(self, options) {`
`1311`	`1311`	`const host = options.host \|\| 'localhost';`
`1312`	`1312`	`let { port, autoSelectFamilyAttemptTimeout, autoSelectFamily } = options;`
`1313`	`1313`
	`1314`	`+ validateString(host, 'options.host');`
	`1315`	`+`
`1314`	`1316`	`if (localAddress && !isIP(localAddress)) {`
`1315`	`1317`	`throw new ERR_INVALID_IP_ADDRESS(localAddress);`
`1316`	`1318`	`}`