src: fix IsIPAddress for IPv6

huseyinacacak-janea · targos · commit 4704270443a6 · 2024-06-20T14:40:42.000+02:00
Fix the bug when copying IPv6 host to a variable to remove brackets. Fixes: #47427 PR-URL: #53400 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com>
diff --git a/src/inspector_socket.cc b/src/inspector_socket.cc
@@ -192,7 +192,7 @@ static bool IsIPAddress(const std::string& host) {
     // Parse the IPv6 address to ensure it is syntactically valid.
     char ipv6_str[INET6_ADDRSTRLEN];
     std::copy(host.begin() + 1, host.end() - 1, ipv6_str);
-    ipv6_str[host.length()] = '\0';
+    ipv6_str[host.length() - 2] = '\0';
     unsigned char ipv6[sizeof(struct in6_addr)];
     if (uv_inet_pton(AF_INET6, ipv6_str, ipv6) != 0) return false;
 
