crypto: check return code from EVP_DigestUpdate

mhdawson · danielleadams · commit 46f714f92a37 · 2022-03-14T09:32:16.000-04:00
Coverity was complaining that we did not check the return code. We seem to check in the other place it is called and the method already handles returning a result. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #41800 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
diff --git a/src/crypto/crypto_hash.cc b/src/crypto/crypto_hash.cc
@@ -122,8 +122,7 @@ bool Hash::HashInit(const EVP_MD* md, Maybe<unsigned int> xof_md_len) {
 bool Hash::HashUpdate(const char* data, size_t len) {
   if (!mdctx_)
     return false;
-  EVP_DigestUpdate(mdctx_.get(), data, len);
-  return true;
+  return EVP_DigestUpdate(mdctx_.get(), data, len) == 1;
 }
 
 void Hash::HashUpdate(const FunctionCallbackInfo<Value>& args) {

Original file line number	Diff line number	Diff line change
`@@ -122,8 +122,7 @@ bool Hash::HashInit(const EVP_MD* md, Maybe<unsigned int> xof_md_len) {`
`122`	`122`	`bool Hash::HashUpdate(const char* data, size_t len) {`
`123`	`123`	`if (!mdctx_)`
`124`	`124`	`return false;`
`125`		`- EVP_DigestUpdate(mdctx_.get(), data, len);`
`126`		`- return true;`
	`125`	`+ return EVP_DigestUpdate(mdctx_.get(), data, len) == 1;`
`127`	`126`	`}`
`128`	`127`
`129`	`128`	`void Hash::HashUpdate(const FunctionCallbackInfo<Value>& args) {`