events: don't call resume after close

ChALkeR · aduh95 · commit 4484e14a31a5 · 2026-02-19T11:14:01.000+01:00
PR-URL: #60548 Fixes: #60507 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
diff --git a/lib/events.js b/lib/events.js
@@ -1074,7 +1074,7 @@ function on(emitter, event, options = kEmptyObject) {
         const value = unconsumedEvents.shift();
         size--;
         if (paused && size < lowWatermark) {
-          emitter.resume();
+          emitter.resume(); // Can not be finished yet
           paused = false;
         }
         return PromiseResolve(createIterResult(value, false));
@@ -1191,6 +1191,7 @@ function on(emitter, event, options = kEmptyObject) {
     abortListenerDisposable?.[SymbolDispose]();
     removeAll();
     finished = true;
+    paused = false;
     const doneResult = createIterResult(undefined, true);
     while (!unconsumedPromises.isEmpty()) {
       unconsumedPromises.shift().resolve(doneResult);
diff --git a/test/parallel/test-readline-async-iterators.js b/test/parallel/test-readline-async-iterators.js
@@ -17,6 +17,7 @@ const testContents = [
   'line 1',
   'line 1\nline 2 &#21335;&#36234;&#22269;&#26159;&#21069;203&#24180;&#33267;&#21069;111&#24180;&#23384;&#22312;&#20110;&#23725;&#21335;&#22320;&#21306;&#30340;&#19968;&#20010;&#22269;&#23478;\nline 3\ntrailing',
   'line 1\nline 2\nline 3 ends with newline\n',
+  Array(1e4).fill(0).map((_, i) => i).join('\n'), // More that 2 * highWaterMark
 ];
 
 async function testSimple() {
@@ -43,6 +44,29 @@ async function testSimple() {
   }
 }
 
+// Same as testSimple, but with Readable.from() instead of fs.createReadStream
+async function testReadableFrom() {
+  for (const fileContent of testContents) {
+    const readable = Readable.from([fileContent]);
+    const rli = readline.createInterface({
+      input: readable,
+      crlfDelay: Infinity
+    });
+
+    const iteratedLines = [];
+    for await (const k of rli) {
+      iteratedLines.push(k);
+    }
+
+    const expectedLines = fileContent.split('\n');
+    if (expectedLines[expectedLines.length - 1] === '') {
+      expectedLines.pop();
+    }
+    assert.deepStrictEqual(iteratedLines, expectedLines);
+    assert.strictEqual(iteratedLines.join(''), fileContent.replace(/\n/g, ''));
+  }
+}
+
 async function testMutual() {
   for (const fileContent of testContents) {
     fs.writeFileSync(filename, fileContent);
@@ -115,6 +139,7 @@ async function testSlowStreamForLeaks() {
 }
 
 testSimple()
+  .then(testReadableFrom)
   .then(testMutual)
   .then(testSlowStreamForLeaks)
   .then(common.mustCall());
