lib: use js-only implementation of `isDataView()` · nodejs/node@430c69d · GitHub
Skip to content

Commit 430c69d

Browse files
Renegade334aduh95
authored andcommitted
lib: use js-only implementation of isDataView()
PR-URL: #62780 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
1 parent c70ff44 commit 430c69d

4 files changed

Lines changed: 10 additions & 18 deletions

File tree

‎benchmark/util/type-check.js‎

Lines changed: 5 additions & 0 deletions

‎lib/internal/util/types.js‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ const {
66
TypedArrayPrototypeGetSymbolToStringTag,
77
} = primordials;
88

9+
function isDataView(value) {
10+
return ArrayBufferIsView(value) && TypedArrayPrototypeGetSymbolToStringTag(value) === undefined;
11+
}
12+
913
function isTypedArray(value) {
1014
return TypedArrayPrototypeGetSymbolToStringTag(value) !== undefined;
1115
}
@@ -61,6 +65,7 @@ function isBigUint64Array(value) {
6165
module.exports = {
6266
...internalBinding('types'),
6367
isArrayBufferView: ArrayBufferIsView,
68+
isDataView,
6469
isTypedArray,
6570
isUint8Array,
6671
isUint8ClampedArray,

‎src/node_types.cc‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ namespace {
1919
V(AsyncFunction) \
2020
V(BigIntObject) \
2121
V(BooleanObject) \
22-
V(DataView) \
2322
V(Date) \
2423
V(External) \
2524
V(GeneratorFunction) \

‎test/parallel/test-util-types.js‎

Lines changed: 0 additions & 17 deletions

0 commit comments

Comments
 (0)