src,permission: fix permission.has on empty param

RafaelGSS · RafaelGSS · commit 428d24acf58a · 2026-01-13T10:04:03.000-03:00
PR-URL: #60674 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
diff --git a/src/permission/fs_permission.cc b/src/permission/fs_permission.cc
@@ -176,13 +176,17 @@ bool FSPermission::is_granted(Environment* env,
     case PermissionScope::kFileSystem:
       return allow_all_in_ && allow_all_out_;
     case PermissionScope::kFileSystemRead:
+      if (param.empty()) {
+        return allow_all_in_;
+      }
       return !deny_all_in_ &&
-             ((param.empty() && allow_all_in_) || allow_all_in_ ||
-              is_tree_granted(env, &granted_in_fs_, param));
+             (allow_all_in_ || is_tree_granted(env, &granted_in_fs_, param));
     case PermissionScope::kFileSystemWrite:
+      if (param.empty()) {
+        return allow_all_out_;
+      }
       return !deny_all_out_ &&
-             ((param.empty() && allow_all_out_) || allow_all_out_ ||
-              is_tree_granted(env, &granted_out_fs_, param));
+             (allow_all_out_ || is_tree_granted(env, &granted_out_fs_, param));
     default:
       return false;
   }
diff --git a/test/parallel/test-permission-has.js b/test/parallel/test-permission-has.js
@@ -1,4 +1,4 @@
-// Flags: --permission --allow-fs-read=*
+// Flags: --permission --allow-fs-read=* --allow-fs-write=.
 'use strict';
 
 const common = require('../common');

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-// Flags: --permission --allow-fs-read=*`
	`1`	`+// Flags: --permission --allow-fs-read=* --allow-fs-write=.`
`2`	`2`	`'use strict';`
`3`	`3`
`4`	`4`	`const common = require('../common');`