crypto: normalize RsaHashedKeyParams publicExponent

panva · targos · commit 427651678157 · 2025-08-21T19:01:15.000+02:00
Fixes: #59535 PR-URL: #59538 Fixes: #59534 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
diff --git a/lib/internal/crypto/util.js b/lib/internal/crypto/util.js
@@ -397,7 +397,9 @@ const kSupportedAlgorithms = createSupportedAlgorithms(kAlgorithmDefinitions);
 
 const simpleAlgorithmDictionaries = {
   AeadParams: { iv: 'BufferSource', additionalData: 'BufferSource' },
-  RsaHashedKeyGenParams: { hash: 'HashAlgorithmIdentifier' },
+  // publicExponent is not strictly a BufferSource but it is a Uint8Array that we normalize
+  // this way
+  RsaHashedKeyGenParams: { hash: 'HashAlgorithmIdentifier', publicExponent: 'BufferSource' },
   EcKeyGenParams: {},
   HmacKeyGenParams: { hash: 'HashAlgorithmIdentifier' },
   RsaPssParams: {},
diff --git a/test/parallel/test-webcrypto-keygen.js b/test/parallel/test-webcrypto-keygen.js
@@ -311,14 +311,20 @@ if (hasOpenSSL(3, 5)) {
     assert.deepStrictEqual(privateKey.usages, privateUsages);
     assert.strictEqual(publicKey.algorithm.name, name);
     assert.strictEqual(publicKey.algorithm.modulusLength, modulusLength);
-    assert.deepStrictEqual(publicKey.algorithm.publicExponent, publicExponent);
+    assert(publicKey.algorithm.publicExponent instanceof Uint8Array);
+    assert.notStrictEqual(publicKey.algorithm.publicExponent, publicExponent);
+    assert(!Buffer.isBuffer(publicKey.algorithm.publicExponent));
+    assert.deepStrictEqual(publicKey.algorithm.publicExponent, new Uint8Array(publicExponent));
     assert.strictEqual(
       KeyObject.from(publicKey).asymmetricKeyDetails.publicExponent,
       bigIntArrayToUnsignedBigInt(publicExponent));
     assert.strictEqual(publicKey.algorithm.hash.name, hash);
     assert.strictEqual(privateKey.algorithm.name, name);
     assert.strictEqual(privateKey.algorithm.modulusLength, modulusLength);
-    assert.deepStrictEqual(privateKey.algorithm.publicExponent, publicExponent);
+    assert(privateKey.algorithm.publicExponent instanceof Uint8Array);
+    assert.notStrictEqual(privateKey.algorithm.publicExponent, publicExponent);
+    assert(!Buffer.isBuffer(privateKey.algorithm.publicExponent));
+    assert.deepStrictEqual(privateKey.algorithm.publicExponent, new Uint8Array(publicExponent));
     assert.strictEqual(
       KeyObject.from(privateKey).asymmetricKeyDetails.publicExponent,
       bigIntArrayToUnsignedBigInt(publicExponent));
