src: don't touch js object in Http2Session dtor

bnoordhuis · MylesBorins · commit 420d56c2ea63 · 2018-03-07T09:30:22.000-08:00
Don't try to update the internal field pointer of the JS object in the destructor. The garbage collector invokes the destructor when the object is collected and is not necessarily in a valid state anymore. Backport-PR-URL: #19185 PR-URL: #18656 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
diff --git a/src/node_http2.cc b/src/node_http2.cc
@@ -531,8 +531,6 @@ Http2Session::Http2Session(Environment* env,
 
 Http2Session::~Http2Session() {
   CHECK_EQ(flags_ & SESSION_STATE_HAS_SCOPE, 0);
-  if (!object().IsEmpty())
-    ClearWrap(object());
   DEBUG_HTTP2SESSION(this, "freeing nghttp2 session");
   nghttp2_session_del(session_);
 }

Original file line number	Diff line number	Diff line change
`@@ -531,8 +531,6 @@ Http2Session::Http2Session(Environment* env,`
`531`	`531`
`532`	`532`	`Http2Session::~Http2Session() {`
`533`	`533`	`CHECK_EQ(flags_ & SESSION_STATE_HAS_SCOPE, 0);`
`534`		`- if (!object().IsEmpty())`
`535`		`- ClearWrap(object());`
`536`	`534`	`DEBUG_HTTP2SESSION(this, "freeing nghttp2 session");`
`537`	`535`	`nghttp2_session_del(session_);`
`538`	`536`	`}`